From list at kjdf.de  Sun Oct 13 09:35:21 2024
From: list at kjdf.de (Dennis Hofheinz)
Date: Sun, 13 Oct 2024 09:35:21 +0200
Subject: Key press when scrollTtyKeypress is enabled does not trigger
 on_view_change hook
Message-ID: <q7zhuoyl7jwj4zwua3xel3b7y7rtvjcdjeeocypjtsag5f3cia@khut6uqyleb2>

Hi,

When the scrollTtyKeypress resource is set to true, and view_start is nonzero,
a keypress should update view_start to zero and trigger a refresh. That works,
but this update does not trigger on_view_change, although I guess it should.
Here's a patch that calls the hook in that case.

Best regards
Dennis

--- a/src/command.C
+++ b/src/command.C
@@ -4167,6 +4167,8 @@
       {
         view_start = 0;
         want_refresh = 1;
+
+        HOOK_INVOKE ((this, HOOK_VIEW_CHANGE, DT_INT, view_start, DT_END));
       }
 
   tt_write_ (data, len);


From andrej.s.korshikov at gmail.com  Thu Nov  7 07:57:16 2024
From: andrej.s.korshikov at gmail.com (Andrei Korshikov)
Date: Thu, 7 Nov 2024 12:57:16 +0600
Subject: urclock second hand is not precise
Message-ID: <CAMvrM3wEFWfpK+-+BR--0aoUwXwLz9jS5CKq0dyhJW3czp9jnw@mail.gmail.com>

I started several instances (less than 5) of urclock and noticed that
second hands for some of them are not in sync. I.e. I can always find
a couple of windows with following behaviour:

1. Window A moves second hand, Window B keeps second hand stopped.
2. Window A keeps second hand stopped, Window B moves.
3. Repeat indefinitely.

So, there is about 0.5 sec noticeable delay.

I use Arch Linux, i3 window manager, and no custom compiler flags.

--
Andrei Korshikov


From emanuele.giaquinta at gmail.com  Mon Dec  2 21:13:45 2024
From: emanuele.giaquinta at gmail.com (Emanuele Giaquinta)
Date: Mon, 2 Dec 2024 22:13:45 +0200
Subject: Key press when scrollTtyKeypress is enabled does not trigger
 on_view_change hook
In-Reply-To: <q7zhuoyl7jwj4zwua3xel3b7y7rtvjcdjeeocypjtsag5f3cia@khut6uqyleb2>
References: <q7zhuoyl7jwj4zwua3xel3b7y7rtvjcdjeeocypjtsag5f3cia@khut6uqyleb2>
Message-ID: <Z04U-fRF2R6PhEdu@gmail.com>

Hi,

On Sun, Oct 13, 2024 at 09:35:21AM +0200, Dennis Hofheinz wrote:
> When the scrollTtyKeypress resource is set to true, and view_start is nonzero,
> a keypress should update view_start to zero and trigger a refresh. That works,
> but this update does not trigger on_view_change, although I guess it should.
> Here's a patch that calls the hook in that case.

thanks for the report and the patch. I committed a fix based on it.

Emanuele


From list at kjdf.de  Tue Dec  3 12:53:11 2024
From: list at kjdf.de (Dennis Hofheinz)
Date: Tue, 3 Dec 2024 12:53:11 +0100
Subject: Key press when scrollTtyKeypress is enabled does not trigger
 on_view_change hook
In-Reply-To: <Z04U-fRF2R6PhEdu@gmail.com>
References: <q7zhuoyl7jwj4zwua3xel3b7y7rtvjcdjeeocypjtsag5f3cia@khut6uqyleb2>
 <Z04U-fRF2R6PhEdu@gmail.com>
Message-ID: <mex62lwbkqezlhdy7lcwk22345da2tv4mnl4y4rtuuk2sufrpp@o5hagn5qbggm>

Hi Emanuele,

Thanks!

Best regards
Dennis

On 2024-12-02, at 21:13:45 +0100, Emanuele Giaquinta wrote:
> Hi,
> 
> On Sun, Oct 13, 2024 at 09:35:21AM +0200, Dennis Hofheinz wrote:
> > When the scrollTtyKeypress resource is set to true, and view_start is nonzero,
> > a keypress should update view_start to zero and trigger a refresh. That works,
> > but this update does not trigger on_view_change, although I guess it should.
> > Here's a patch that calls the hook in that case.
> 
> thanks for the report and the patch. I committed a fix based on it.
> 
> Emanuele