[PATCH] Fix not sending XEMBED_REQUEST_FOCUS

[Marc Lehmann]

On Sat, Feb 22, 2014 at 05:18:04PM +0100, Olivier Brunel <jjk at jjacky.com> wrote:
> When using -embed and the window is clicked, if we didn't have the focus
> we should send XEMBED_REQUEST_FOCUS to the embedder to get it (i.e. it
> will respond by sending us a XEMBED_FOCUS_IN).

Hi!

I've read through the xembed spec again, but I don't think urxvt should
send such a request. urxvt doesn't have a click-to-focus focus model, it
would be the responsibility of the wm (or the embedder) to manage focus.

Click-to-focus would implement a policy that is not up to urxvt to decide.
It's up to the embedder to decide which focus policy to implement.

Thinking about it a bit more, it seems that this is a serious flaw in
xembed - basically, the only way to get good default behaviour is to have
a window manager using click-to-focus (probably because the authors of the
xembed spec use window managers or widget models using click-to-focus),
leaving other focus models badly supported.

I will bring this up on the next maintainer meeting, but I suspect that
urxvt will not enforce a click-to-focus model on embedders, and it's the
responsibility of the embedder to emulate the window managers focus model
(or the focus model of its choice).

The only problem here is that click-to-focus probably can't be
implemented, due to limitations in xembed itself.

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      schmorp at schmorp.de
      -=====/_/_//_/\_,_/ /_/\_\