[PATCH] Only ongrab kuake hotkey if the $term is not embedded.

[Marc Lehmann]

On Tue, Dec 06, 2011 at 05:27:20PM +0100, Mark Pustjens <pustjens at dds.nl> wrote:
> 
> When using urxvt-tabbedex (https://github.com/stepb/urxvt-tabbedex)
> in combination with kuake. (probably also with the tabbed
> extension).

That makes sense.

The problem here is that you enable kuake for multiple terminals, but only
one terminal can have kuake enabled.

You could try to enable it only for the embedding terminal, by using
URxvt.tabbed.perl-ext: or something like that, but I am not sure that
works.

The problem with your patch is that it doesn't really make any sense to
disable kuake for embedded terminals - users who embed their terminal and
enable kuake might have good reasons to do so.

> When you have a few tabs open, and close one of them on_destroy is
> called for that embedded urxvt instance. This handler Ungrabs the
> hotkey. However, the window is still open, with another tab (and
> hence embedded instance of urxvt).

Only one terminal can sensible have the kuake extensino enabled - this is
kind of specific to kuake, because it modifies global desktop state (the
hotkey), and consequently requires the user to think about which terminal
has it enabled.

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      schmorp at schmorp.de
      -=====/_/_//_/\_,_/ /_/\_\