[PATCH] Support freedesktop startup notifications
Mikael Magnusson
mikachu at gmail.com
Sun Nov 13 17:57:56 CET 2011
On 13 November 2011 16:42, Michael Stapelberg
<michael+urxvt at stapelberg.de> wrote:
> Hi Mikael,
>
> Excerpts from Mikael Magnusson's message of 2011-11-13 15:12:05 +0000:
>> > Hello, the patch looks fine, but there are some code style issues.
>> > - the ./configure --help line should have two spaces separating the
>> > help text from the option name when the name is too long.
>> > - use a space before opening ( even for function calls and macros.
>> > - put an empty line after }
>>
>> I forgot to add that the option also needs to be documented in
>> rxvt.7.pod under "configure options".
>>
>> > If you fix these issues we will apply the patch, thanks.
> Everything fixed, thanks for the feedback.
>
> I attached the updated version of this patch.
Thanks, I've applied the patch to CVS.
--
Mikael Magnusson
More information about the rxvt-unicode
mailing list