[PATCH] Support freedesktop startup notifications

[Mikael Magnusson]

On 13 November 2011 16:07, Mikael Magnusson <mikachu at gmail.com> wrote:
> On 12 November 2011 17:37, Michael Stapelberg
> <michael+urxvt at stapelberg.de> wrote:
>> Hi,
>>
>> attached you can find a patch which implements support for freedesktop startup
>> notifications [1]. These are used by popular desktop environments such as KDE,
>> GNOME, Xfce and niche window managers such as awesome, openbox, matchbox, i3
>> and possibly others.
>>
>> The purpose of startup notifications is to communicate to the window manager
>> when the application startup is complete, so that it can display some kind of
>> progress indicator during startup. Also, X11 windows get the _NET_STARTUP_ID
>> property so that window managers can correlate the startup event and resulting
>> windows (allowing to place them on the correct virtual desktop, for example).
>>
>> The code changes are quite small (25 lines, including ifdefs/includes/newlines)
>> and support for startup notifications can be disabled using the
>> --disable-startup-notification compile time flag. Startup notifications work
>> properly when using urxvt and when using urxvtc/urxvtd.
>>
>> Please merge this patch for the next release. If you have any questions, do not
>> hesitate to contact me. Thanks.
>
> Hello, the patch looks fine, but there are some code style issues.
> - the ./configure --help line should have two spaces separating the
> help text from the option name when the name is too long.
> - use a space before opening ( even for function calls and macros.
> - put an empty line after }

I forgot to add that the option also needs to be documented in
rxvt.7.pod under "configure options".

> If you fix these issues we will apply the patch, thanks.

-- 
Mikael Magnusson