shift+pageup/pagedown behaviour

[Marc Lehmann]

On Mon, Mar 14, 2011 at 08:30:32PM +0100, Tomas Cech <sleep_walker at suse.cz> wrote:
> I started recently to modify the terminal behaviour for
> shift+pageup/pagedown key presses in alternate screen mode. Since
> alternate screen has exact size as visible part of terminal screen,
> these key combintations doesn't have that good reason for history
> scrolling.

Not really, both primary and secondary screen are the same size, the
scrollback is shared, and it's behaviour can be configured via various
resources (e.g. look at secondaryScroll).

> application running inside terminal. I see this as possibility for
> programs like screen and tmux that they can provide history of their
> terminal more naturally.

At least screen already has keybindings for history scrolling and
searching, while your patch apparently implements something that screen
doesn't use yet, while leaving history searches broken.

> shift+up/down doesn't work at all. I hope that the idea is clear.

Reasonably well to me, I hope, but it seems you create a bigger mess than
before - at least, right now, it's consistent.

> -                }
> +				  if (current_screen == SECONDARY && option(Opt_secondarySendScroll)) {

Also, your patch is absolutely horribly formatted - as a general hint: if
you are interested in having a patch applied by the maintainers of some
software, you should follow the existing coding style, as a minimum. as it
is, the patch is completely unreadable for me.

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      schmorp at schmorp.de
      -=====/_/_//_/\_,_/ /_/\_\