[PATCH] urxvtd, getopt and mlock

[Marc Lehmann]

On Thu, Jan 22, 2009 at 02:56:56PM -0500, Russell Harmon <russ at eatnumber1.com> wrote:
> I merged the getopt_long patch and the mlock patches (since they modified
> the same code).

Sorry for the delay.

Since urxvt is still aiming for low memory suage, what actual advantage
does usage of getopt_long bring, except being unportable and thus
requiring both old and new code? It is unlikely thta any advantages would
outweigh the disadvantages.

> I cleaned up the patch a bit. It now is enabled via the configure script
> with the --enable-mlock flag, the flag is now -m/--mlock (instead of
> -l/--lock).

If you could just send in the mlockall patch with configure support, but
without enable switch, that would be fine (instead, it should be enabled
on ENABLE_FRILLS).

I.e. --mlock should simply be available when compiled with frills on any
system that supports it, this patch would go in immediately.

Great to hear that the mlockall bug has been fixed, although I definitely
see the bug with debians glibc-2.7 (I reported that bug against glibc-2.7
in april of last year), so this is definitely worth considering.

> I renamed --opendisplay to --open-display (opendisplay is improper english).

And so is --open-display... it's a technical term.

> Note that for the manpages, I updated the rxvtd.1.pod file, so the
> rxvtd.1.man.in file will need to be regenerated.

Absolutely great :)

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      pcg at goof.com
      -=====/_/_//_/\_,_/ /_/\_\