Patch for _NET_WM_ICON
ich at frank-schmitt.net
Tue Nov 4 10:43:11 CET 2008
Marc Lehmann <schmorp at schmorp.de> writes:
> On Tue, Nov 04, 2008 at 10:28:54AM +0100, Frank Schmitt <ich at frank-schmitt.net> wrote:
>> > If you can't be bothered for simple and obvious things like following the
>> > *existing* coding style of a project, then I can't be bothered to waste
>> > time on your patch, really.
>> Let's stop the discussion here.
> You see, your behaviour boils down to this: first you agree to finish the patch
> after fixing the syntax. I then invest a lot of time into it, and the result
> is you not complying and calling me nitpicking.
> If you think that behaviour is fine, I am surprised, but that's how is it.
> It's up to you to think about it. Maybe you shouldn't agree to something
> if you can't be bothered to go through with it and all you cna do is
> insult people when they call in what you agreed to.
I really tried to follow your wishes. I did not want to annoy you and
I'm sorry that I did by not preparing the patch carefully enough.
However, I was annoyed, too that you insisted that e.g. the
ASImage *im = file2ASImage(rs [Rs_iconfile], 0xFFFFFFFF, SCREEN_GAMMA, 0, NULL);
was wrong while it definitely wasn't and didn't get that you not only
wanted GNU style curly braces and a space before the ( and around = but
also spaces around arithmetic symbols. If you had just told me that yesterday,
things would have gone a much smoother way. Of course if I had looked at
the existing code more carefully, that would have been the case too.
So, again: Sorry.
Have you ever considered how much text can fit in eighty columns? Given that a
signature typically contains up to four lines of text, this space allows you to
attach a tremendous amount of valuable information to your messages. Seize the
opportunity and don't waste your signature on bullshit that nobody cares about.
More information about the rxvt-unicode