Small bug in tabbed extension

Matthew "Cheetah" Gabeler-Lee cheetah at fastcat.org
Fri Jun 2 03:53:04 CEST 2006


I just found rxvt-unicode today, and yay :)  One particular yay for the 
way I tend to work is the tabbed extension.  I found one minor bug with 
it: It subtracts 1 from the height given by a geometry spec.  So if I 
run rxvt -geometry 80x25, I get a window that is 80x24.  I checked this 
with several values, and it was consistent, until I got to very small 
sizes.  80x1 not surprisingly produced a stream of XLib errors, since 
there was no room for the terms, only for the tab bar.  80x2 gave an 
80x2 window (tab bar and 80x1 term), 80x3 started the -1 behavior, 
giving the same 80x2 window.

I looked through the perl code for the tabbed extension, but I didn't 
find any bits that looked immediately suspicious.  The closest I found 
to suspicion was the calculation of $self->{tabheight} in on_start(), 
and the height calculations in the calls to XMoveResizeWindow in 
configure().

(I'm not subscribed, please CC me on replies :)
-- 
	-Cheetah
"Reality is that which, when you stop believing in it, doesn't go away".
                -- Philip K. Dick
GPG pubkey fingerprint: A57F B354 FD30 A502 795B 9637 3EF1 3F22 A85E 2AD1




More information about the rxvt-unicode mailing list