$DEFINE in Coro's Makefile.PL appears unused (albeit without apparent consequence)

Kent Fredric kentfredric at gmail.com
Thu Oct 5 08:18:52 CEST 2017


I was looking through Coro's Makefile.PL and saw a careful construction of:

$DEFINE .= " -DHAVE_EVENT=1";

and

$DEFINE .= " -DHAVE_EV=1";

But I couldn't for the life of me work out where $DEFINE is used.

I suspect it might have been intended to pass it in WriteMakefile( ),
but history indicates the variable has been unused since Coro 0.65
when it was first defined.

But it seems all inconsequential because I can't see any place in the
source where those defines are actually consumed,  so the only real
problem here I think is people like me might read this file once in a
blue moon and get confused like I did :)

Thanks.

-- 
Kent

KENTNL - https://metacpan.org/author/KENTNL



More information about the perl mailing list