[PATCH] Fixed Android support

Marc Lehmann schmorp at schmorp.de
Thu Jun 1 05:15:20 CEST 2017


On Tue, May 30, 2017 at 05:28:07PM -0700, enh <enh at google.com> wrote:
> The attached patch fixes Android NDK bug
> https://github.com/android-ndk/ndk/issues/396 --- basically the
> presence of EPOLL_CLOEXEC doesn't necessarily imply the presence of
> epoll_create1 on Android. This is because (as of NDK r15) we're using

If android uses header files that don't match it's libc *on purpose* then
android is way beyond broken.

> Gingerbread, you'll have all the enums and macros and structs from
> Marshmallow and O. so you actually need a proper configure test for
> epoll_create1.

configure is optional for libev, so a "proper" test wouldn't work.

This is clearly a bug in the android headers, and since it apparently only
affects old versions, I don't think it makes sense to make things worse
for users of higher quality platforms that have correct header files.

I would suggest opening a bug against android so these obvious bugs get
fixed instead of trying to push patches to the rest of the world to work
around it.

Unrelated, the __ANDROID__ change will be in the next release.

Greetings,

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      schmorp at schmorp.de
      -=====/_/_//_/\_,_/ /_/\_\



More information about the libev mailing list