libeio: discrepancy between the manual and the code

[Konstantin Osipov]

Hello,

libeio manual says that:

--quote
Even if cancelled, the finish callback will still be invoked - the callbacks
of all cancellable requests need to check whether the request has been
cancelled by calling EIO_CANCELLED (req):
--end quote

Yet in the implementation does not do this
(http://cvs.schmorp.de/libeio/eio.c):

#ifndef EIO_FINISH
# define EIO_FINISH(req)  ((req)->finish) && !EIO_CANCELLED (req) ? (req)->finish (req) : 0
#endif

In my view, it's important to make sure the callback is always, 
otherwise it's hard to reliably manage resources associated
with eio function arguments.

-- 
http://tarantool.org - an efficient, extensible in-memory data store