Patch for libeio

Marc Lehmann schmorp at schmorp.de
Tue Mar 6 11:28:05 CET 2012


On Tue, Mar 06, 2012 at 10:23:39AM +0100, Pierre-Yves Kerembellec <py.kerembellec at gmail.com> wrote:
> - remove trailing commas in enums in eio.h (since C++ does not allow them).

Hmm, libeio is C, not C++, but even C++ does allow trailing commans in
enums, see 7.2p1:

   enum-specifier:
        enum-head { enumerator-list(opt) }
        enum-head { enumerator-list , }

> - add an opaque applicative pointer in eio_init, passed to both want_poll_cb and done_poll_cb
>   callbacks afterwards (this is not to support multiple event loops but to ease C++ integration
>   when the event loop is not a globally-accessible static symbol but part of an object members
>   instead).

Since that's equivalent to using a global variable (or a static
object member), what would the purpose of the patch be except to add
overhead? What aspect of C++ integration would become easier?

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      schmorp at schmorp.de
      -=====/_/_//_/\_,_/ /_/\_\



More information about the libev mailing list