libecb memory fence on s390 and s390x

Marc Lehmann schmorp at schmorp.de
Fri Jan 27 23:25:23 CET 2012


On Sat, Jan 28, 2012 at 02:06:23AM +0400, Alexey Borzenkov <snaury at gmail.com> wrote:
> I recently fixed support for s390 and s390x in greenlet, which was
> needed for the latest version of gevent. However, after we greenlet
> finally worked, latest gevent (which uses libev)

bleeding edge cvs user - I'd hope we'd have more of those :)

> installed, because there's no support for memory fence in libecb. I
> just looked into gcc sources and it defines memory_barrier for s390 as
> "bcr\t15,0" (conditional branch on all conditions that is used for
> synchronization, see

Thanks a lot - I assume this was a gcc version < 4.4 and you looked at >=
4.4?

> which seems to make sense. Could you please add it to libecb and libev
> too? Here's the patch:

will do (your other patch), thansk for writing it!

> Haven't asked that person to test it yet, but given the docs and the
> use by gcc it should be straight forward.

Yeah, why ever would we need to test if it's so obviously correct :*)

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      schmorp at schmorp.de
      -=====/_/_//_/\_,_/ /_/\_\



More information about the libev mailing list