[PATCH]: libev-3.8; ev++.h bug and warning fixes.
schmorp at schmorp.de
Fri Aug 28 15:09:38 CEST 2009
On Fri, Aug 28, 2009 at 02:33:00PM +0400, Konstantin Lepa <konstantin.lepa at gmail.com> wrote:
> I use C++ only (freebsd 7.2). I'd prefer to compile my source code with
> -pedantic and -Wextra
that is fine with me.
> It annoys and disturbs me to find real problems.
Then please fix your real problems and don't send patches that actively
break libev and claim it would be unusable without them?
> Enum problem:
> /usr/local/include/ev++.h:79: error: comma at end of enumerator list
That is the single case where we indeed rely on the next c++ standard,
and g++ (and most other compilers) support it, so this is your problem to
deal with. I won't change correct code because you think you have to use
compiler switches that are not recommended by the compiler vendor.
> Warnings generated by -Wextra:
Please read the libev documentation regarding this first.
> EV_P_ is "struct ev_loop *loop,". And it generates warning of unused
> loop variable.
That's a problem with your compiler (more specifically your settings) -
the code is valid C++.
If that is indeed a real problem for you, then you are the only one who
cna fix it, as the problem is outside of libev's code.
> Prototype of IOEventManager::Cleanup is "void
That is not part of libev. Since ev++.h works with a lot of toher
packages, this is most likely a bug in your program - see for example
rxvt-unicode for actual uses of ev++.h that are correct.
(If you disagree, please give a small example program, so far, you just
made a lot of claims without bringing any evidence that there is a problem
in libev, but proof that there is a problem with your set up).
The choice of a Deliantra, the free code+content MORPG
-----==- _GNU_ http://www.deliantra.net
----==-- _ generation
---==---(_)__ __ ____ __ Marc Lehmann
--==---/ / _ \/ // /\ \/ / pcg at goof.com
More information about the libev