[PATCH]: libev-3.8; ev++.h bug and warning fixes.
Marc Lehmann
schmorp at schmorp.de
Fri Aug 28 10:42:15 CEST 2009
On Fri, Aug 28, 2009 at 12:11:39PM +0400, Konstantin Lepa <konstantin.lepa at gmail.com> wrote:
> 1. Fixed warnings for compilation with -pedantic flag.
ev++.h is written in C++, not in any other language. If you compile ev++.h
with any othe rlanguage, that's your problem and doesn't make ev++.h
unusable as you claim.
> 2. Fixed errors in template member functions.
- static void method_thunk (EV_P_ ev_watcher *w, int revents)
+ static void method_thunk (struct ev_loop *, ev_watcher *w, int
revents)
sorry, your patch is completely bogus. you need to explain why warnings
make ev++.h unusable, or why your compiler doesn't support macro
expansion.
note that your patch *breaks* ev++.h and makes it unusable.
in any case, try a c++ compiler (ev++.h currently relies on some syntax
extensions that are part of the next version of c++, but compiles fine
with current c++ compilers - you can always use gcc).
> ev++.h isn't usable without the patch.
bullshit, it's obviously usable by many projects, including urxvt, which
runs on a very wide variety of platforms.
--
The choice of a Deliantra, the free code+content MORPG
-----==- _GNU_ http://www.deliantra.net
----==-- _ generation
---==---(_)__ __ ____ __ Marc Lehmann
--==---/ / _ \/ // /\ \/ / pcg at goof.com
-=====/_/_//_/\_,_/ /_/\_\
More information about the libev
mailing list