[patch] event_loopbreak()

[Marc Lehmann]

On Tue, Jul 07, 2009 at 12:22:16AM +0400, Antony Dovgal <tony at daylessday.org> wrote:
> I'd like to propose a patch adding support for event_loopbreak(), event_base_loopbreak() and ev_break():
> http://dev.daylessday.org/diff/libev_event_loopbreak.diff

hmm, you also add some (unexplained) functionality to ev.c - I assume
event_break is some new libevent functionality?

Since I couldn't quickly find any useful documentation on these new
functions, and you didn't provide one, what are they supposed to do?

libevent documents them as:

   Abort the active event_base_loop() immediately.
   event_base_loop() will abort the loop after the next event is completed

Your patch, howver, implements ev_unloop in a different way, so it seems
superfluous.

Assuming your patch is flawed and your intention was to implement the
function as dcoumented by libevent, I am still reluctant to slow down one
of the central inner loops, and libev seems to be strong enough nowadays
as to not require full libevent api support anymore, so, what's a use case
for this, I cannot imagine any?

> I didn't actually use or see libev until today, so bear with me if the patch is wrong/incomplete.

That's fine :) I still need more explanations before applying patches in
general, though.

(I assume the patch is a proof-of-concept patch, if I were to accept
the feature, it would need documenttaion, proper formatting, and the
MULTIPLICITY changes need to be removed - but I still need a good reason
for this functionality).

Greetings,

-- 
                The choice of a       Deliantra, the free code+content MORPG
      -----==-     _GNU_              http://www.deliantra.net
      ----==-- _       generation
      ---==---(_)__  __ ____  __      Marc Lehmann
      --==---/ / _ \/ // /\ \/ /      pcg at goof.com
      -=====/_/_//_/\_,_/ /_/\_\